refactor(dfir_lang): remove stratum, add push codegen for lattice_fold, lattice_reduce, _lattice_fold_batch#2970
Open
MingweiSamuel wants to merge 2 commits into
Open
refactor(dfir_lang): remove stratum, add push codegen for lattice_fold, lattice_reduce, _lattice_fold_batch#2970MingweiSamuel wants to merge 2 commits into
lattice_fold, lattice_reduce, _lattice_fold_batch#2970MingweiSamuel wants to merge 2 commits into
Conversation
Deploying hydro with
|
| Latest commit: |
bfc267f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34fad758.hydroflow.pages.dev |
| Branch Preview URL: | https://mingwei-newpush-latticefold.hydroflow.pages.dev |
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
from
66afb59 to
869360d
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
cfdd3bb to
73a8e26
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
from
869360d to
c931247
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
73a8e26 to
f170cf6
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
from
c931247 to
622f695
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
f170cf6 to
275834c
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
2 times, most recently
from
b3b3204 to
2e25dc3
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
275834c to
5be7095
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
from
2e25dc3 to
59d1ce2
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
2 times, most recently
from
5f1f6ac to
0177c8e
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
2 times, most recently
from
18b7869 to
d1ebaa7
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
0177c8e to
774fd27
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
774fd27 to
fe64bfe
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
from
d1ebaa7 to
080af6c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors DFIR language operator codegen for lattice folding/reducing operators by removing monotone-accum delay barriers and allowing lattice_fold / lattice_reduce to be codegenerated in non-pull contexts, with corresponding updates to graph visualization snapshots in dfir_rs tests.
Changes:
- Remove
DelayType::MonotoneAccuminput delay typing fromlattice_fold,lattice_reduce, and_lattice_fold_batchoperator constraints. - Make
lattice_reducecodegen conditional onis_pull(only inject pull-specific type checks when in pull mode). - Update graphvis Mermaid/DOT snapshots to reflect the simplified graph structure (fewer handoffs / different subgraph clustering) resulting from barrier removal and fusion changes.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dfir_lang/src/graph/ops/lattice_reduce.rs | Removes monotone-accum delay typing and gates pull-only input trait checks behind is_pull. |
| dfir_lang/src/graph/ops/lattice_fold.rs | Removes monotone-accum delay typing and delegates to fold without asserting pull-only mode. |
| dfir_lang/src/graph/ops/_lattice_fold_batch.rs | Removes monotone-accum delay typing for the batch-fold fusion operator (still pull-only). |
| dfir_rs/tests/snapshots/surface_singleton__fold_cross@graphvis_mermaid.snap | Snapshot update reflecting new graph edges/subgraph layout after barrier removal. |
| dfir_rs/tests/snapshots/surface_singleton__fold_cross@graphvis_dot.snap | DOT snapshot update matching the new graph structure. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick@graphvis_mermaid.snap | Snapshot update reflecting handoff/barrier changes in the generated graph. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick@graphvis_dot.snap | DOT snapshot update matching the new graph structure. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick_tee@graphvis_mermaid.snap | Snapshot update reflecting handoff/barrier changes in the generated graph. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick_tee@graphvis_dot.snap | DOT snapshot update matching the new graph structure. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick_identity@graphvis_mermaid.snap | Snapshot update reflecting handoff/barrier changes in the generated graph. |
| dfir_rs/tests/snapshots/surface_lattice_bimorphism_persist_insertion__cartesian_product_multi_tick_identity@graphvis_dot.snap | DOT snapshot update matching the new graph structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
fe64bfe to
efcc46e
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
2 times, most recently
from
15e1108 to
9c98e2d
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
efcc46e to
d08ff6c
Compare
shadaj
approved these changes
Jun 23, 2026
| #write_iterator | ||
| } | ||
| } else { | ||
| write_iterator |
Member
There was a problem hiding this comment.
No need for type guards in the push version?
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
d08ff6c to
f5c2ee5
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
2 times, most recently
from
7282015 to
bfc267f
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
f5c2ee5 to
0d99a0e
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
from
bfc267f to
2f4c8ad
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
2 times, most recently
from
1e71fe5 to
23d59a1
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
from
2f4c8ad to
04e3def
Compare
…mut`, `persist_mut_keyed` PR: #2969 Remove unnecessary Vec allocation in persist_mut push-side and add second-tick test assertions - dfir_lang/src/graph/ops/persist_mut.rs: Removed `.collect::<Vec<_>>()` from the push-side `flat_map` closure. The iterator from `state.iter().cloned()` is now streamed directly without an intermediate allocation. Added a `check_push` helper function (matching the pattern used in `persist_mut_keyed.rs`) to properly handle the lifetime of the borrowed state reference. - dfir_rs/tests/surface_push_blocking.rs: Updated `test_persist_mut_push` and `test_persist_mut_keyed_push` to use `source_stream` instead of `source_iter` and added second-tick assertions that verify the persistence operator replays its current state on subsequent ticks. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2969
…ld`, `lattice_reduce`, `_lattice_fold_batch` PR: #2970
MingweiSamuel
force-pushed
the
mingwei/newpush-latticefold
branch
from
04e3def to
e5d268f
Compare
MingweiSamuel
force-pushed
the
mingwei/newpush-persist
branch
from
23d59a1 to
0b3f613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.